Added remote control commands for IQ recording #1405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add this partially implements this requested feature |
|
By the way, there is a previous pull request implementing the same feature (but using different commands): #1142 Perhaps we should revive that pull request instead? |
|
I will work on that branch then -- may I ask the preferred procedure? Just branch off of that branch, merge master, test and open another PR? |
In case of conflict, fix the code, add changed files and
This should result in a clean history without "Merge master into..." useless commits. |
|
I rebased #1142 and pushed the changes (since I have permission as the project maintainer). My suggestion would be to try out that branch and leave your feedback on that PR. |
|
Closing in favour of #1142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expanded the remote control / telnet commands to include AOIQ and LOIQ to emulate the AOS and LOS commands to capture the IQ data instead of audio. I connected the remote control commands to the IQ tool by making a public pointer in remote control point to the IQ tool.
I tested my changes by opening two shells and launching gqrx from the first shell and enabled TCP communications. On the second shell, I then ran telnet and sent the AOIQ and LOIQ commands to GQRX, confirming RPRT 0 responses:
I then checked that a .raw file was created where specified in the gqrx configuration, and that was indeed a collection of IQ data I was able to play back in GQRX to show functionality.